[Tracking] Simulation Interface #253

benflexcompute · 2024-05-08T20:24:02Z

No description provided.

* added strucuture and interface for Simulation object update design with some grouping and renaming, added user_stories to fill in Added example FORMAT Added the diagram Added stripped Flow360BaseModel Removed allow_but_remove WIP on updating the BaseModel to pydantic V2 WIP Add more docstring for details * Updated the base model to V2 in simulation * Fix unit test * Lint * fresh install * Add CI to UnderConstruction/SimulationInterface * Try again * Try again * Try again --------- Co-authored-by: benflexcompute <ben@flexcompute.com>

* added geometry api * address comments

* Added meshing Param * remove temp file * Finished field population, will refine tomorrow * Added more examples * Changed models according to discussion. Will change examples now * Applied the suggestions to examples too * More example fixes * Fix more examples * Removed Simulation class

comments addressed lint print version of isort

…losure (#264)

examples/simulation_examples/rotation.py

* Entities implementation completed. The rest of relevant work is how and when _expand_entities function is called Created folder for new tests Removed ambiguity in implementation Fix format Applied Maciej's suggestion, trying to abstract it now Added EntityList Added default expansion to all entities Added input validation and more unit tests None input validation * Removed the use of global registry * Raise error when valid_types is None * Removed comments and unnecessary comment * comments addressed * Address final decorator comment * Fix unit test

* [ModelRef] Added Field Definitions for **UserDefinedDynamics** format * Update

…fault for it when EntityList is not required (#277)

* [ModelRef] Added Field Definitions for Outputs Removed test artifacts Fix format * Added Entity Implementation * Comments addressed * Fix unit test * Addressed comments * Fix unit test?

* basic support for pydantic v2 supported in unit system * implemented pydantic v2 support for unit system constrained types * attempt to use json encoders for unyt quantities * WIP - Splitting unit system implementations, supporting unit system in pydantic 2 * WIP - Fix runtime errors after pydantic v2 migration, fix tests * Fixed serialization issues * Fix schema issues and tests * Test fixes * Style fixes * Migrate Axis and Vector types to support pydantic v2, remove pd1-specific types from type definitions * Remove print statements and leftover code from legacy unit system class * Fix temperature type validator in pydantic v2 version --------- Co-authored-by: Andrzej Krupka <andrzej@flexcompute.com>

* [ModelRef] Added Field Definitions for **TimeStepping** Comments addressed * Comments addressed * Update default

* [ModelRef] Added Field Definitions for **ReferenceGeometry** * added some thoughts in docstring * Fix unit test

* create surface mesh from geometry id * remove _0 in the naming * rename an example file * address comments * address comments * fix key in Cylinder class * fix path of resources in examples * remove dev env settting; keep geometry file name in remote * added preprod env handling (#282) Co-authored-by: Feilin <52168719+feilin-flexcompute@users.noreply.github.com> * use dev in geometry example * address comments * fix surface mesh cylinder from 3rd party * remove iges support --------- Co-authored-by: Maciej Skarysz <83596707+maciej-flexcompute@users.noreply.github.com>

* fix surface_mesh and upload examples for surface meshing * lint

* Symmetry Plane * Added XV15HoverMRF + fixed C_D and C_DES for kOmegaSST * Added NestedCylindersSRF * Fixed unit test * Added heatFluxCylinder * Added plateASI

* Add discriminator for some single attribute models * Fix unit tests

* Rename Probe to ProbeGroup to avoid confusion * Corrected alias

* Fix missing value error in __init__ signature * Removed debug code

* The surface mesh generation works. Now we try to generailize it * Revert flow360/ changes * Self review now * Fix lint * Add log * Chenage warning * Fix lint * Move old requests to requests_v1 * Put the reqeust_v2 as request * MV geometry to geometry_V1 * Moved v2 geometry to geometry * interface --> interface_v1 * geometry_v2 --> geometry * Renamed resource_base to resource_base_v1 * resource base v2 --> resource_base * change import * Add path API for future use * self review * MERGE flow360/cloud/requests_v1.py and flow360/cloud/requests.py * Corrected imports from interfaces_v1 * MERGE resource_base_v1 and resource_base * Removed deferred_400_error_handling * List options for valid meshing units * Address comments * Added test * moved solver version into the constructor of draft * Format * fix pytest * Comment addressed * Added cloud module * Fix UUID validation check * Address comments

.github/workflows/test.yml

.github/workflows/codestyle.yml

…ction branch

maciej-flexcompute · 2024-08-01T16:07:14Z

flow360/component/flow360_params/conversions.py

+    def get_base_angle():
+        # pylint: disable=no-member
+        return 1 * u.rad


I think base values are unitless. I think this will break. Do we have any usage or test for converting angles?

I do not think we used to have any angle type in Flow360Params

flow360/component/flow360_params/params_base.py

maciej-flexcompute · 2024-08-01T16:17:22Z

flow360/component/flow360_params/updater.py

@@ -18,6 +18,7 @@ def _no_update(params_as_dict):
    ("23.3.0", "23.3.*", _no_update),
    ("23.3.*", "24.2.*", _no_update),
    ("24.2.*", "24.2.*", _no_update),
+    ("24.2.*", "24.3.*", _no_update),  # we should not allow to submit Flow360Params to version 24.3


do we have release 24.3 ? I don't think so. I think this should be update from 24.2 to 24.7. But the problem we might get is with all the JSONs generated in the past months, they might have version 24.3.0 inside

Right. Let's keep this as it for now. If 24.7 cannot wait for the simulation then we also add it here then.

maciej-flexcompute · 2024-08-01T16:19:38Z

flow360/component/geometry_v1.py

do we want to keep this file?

It is not used anywhere except examples. Let's remove this.

maciej-flexcompute · 2024-08-01T16:24:17Z

flow360/component/simulation/cloud.py

+def run_case(source_asset: AssetBase, params: SimulationParams, async_mode: bool = True):
+    """run case from the geometry"""
+    return _run(source_asset, params, Case, async_mode)


since
geometry -> case, or
volume_mesh -> case
will be the most often used options, can we alias this to "run"?

Suggested change

def run_case(source_asset: AssetBase, params: SimulationParams, async_mode: bool = True):

"""run case from the geometry"""

return _run(source_asset, params, Case, async_mode)

def run(source_asset: AssetBase, params: SimulationParams, async_mode: bool = True):

"""run case from the geometry"""

return _run(source_asset, params, Case, async_mode)

also, how user will provide name for new case?

I think run_case is fine. It is not a very long name. run makes it seems like there should be an argument to specify the destination.

Now the case name appears to be Case_${draft name}. We need back end change for a complete support for user specified case name.

maciej-flexcompute · 2024-08-01T19:01:27Z

flow360/component/simulation/user_story_examples/debug_divergence_by_change_mesh_para.py

I think we need to delete entire user_story_examples

flow360/component/validator.py

flow360/examples/base_test_case.py

tests/pytest.ini

tools/integrations/data_v2/UDD/UserDefinedDynamic-release-24.6.json

* Fix https://flow360.atlassian.net/browse/SCFD-2383 * Fix https://flow360.atlassian.net/browse/SCFD-2385 * Fix https://flow360.atlassian.net/browse/SCFD-2386 * Changed degC seralization * Fixed https://flow360.atlassian.net/browse/SCFD-2398 testing now * Fix test * FixBug * Address comment

maciej-flexcompute · 2024-08-01T22:49:10Z

flow360/component/simulation/operating_condition.py

+        # Standard atmosphere constants
+        t0 = 288.15 * u.K  # Sea level standard temperature
+        p0 = 101325 * u.Pa  # Sea level standard pressure
+        lapse_rate = 0.0065 * u.K / u.m  # Temperature lapse rate
+        r = Air().gas_constant  # Specific gas constant for dry air
+        g0 = 9.80665 * u.m / u.s**2  # Standard gravity
+
+        # Calculate temperature at the given altitude
+        temperature = t0 - lapse_rate * altitude
+        temperature += temperature_offset

+        # Calculate pressure at the given altitude
+        pressure = p0 * (1 - (lapse_rate * altitude / t0)) ** (g0 / (r * lapse_rate))
+
+        # Calculate density at the given altitude
+        density = pressure / (r * temperature)
+
+        # Construct and return the thermal state
+        state = cls(density=density, temperature=temperature, material=Air())


not sure where this model comes from, but I think implementation of US standard atmosphere model is more complex, here is one implementation: https://github.com/flexcompute/design360/blob/develop/design360/client/utils/atmosphere_model.py

I copied your implementation

maciej-flexcompute and others added 2 commits May 1, 2024 14:58

Merge branch 'develop' into UnderConstruction/SimulationInterface

1b64d6c

benflexcompute added WIP future-release labels May 9, 2024

benflexcompute changed the title ~~Simulation Interface~~ [Tracking] Simulation Interface May 9, 2024

feilin-flexcompute and others added 8 commits May 14, 2024 11:57

API for geometry (#257)

a3cacea

* added geometry api * address comments

Fix PorousMedium example error noticed by YiFan

57610b7

isort

c930b2d

add version to surface meshing params (#259)

7d05cda

comments addressed lint print version of isort

Merge branch 'develop' into UnderConstruction/SimulationInterface

28dbe96

Fix windows unit test failure because of accessing temp file before c…

79865b6

…losure (#264)

Merge branch 'develop' into UnderConstruction/SimulationInterface

90b7795

yifan-flex reviewed May 20, 2024

View reviewed changes

examples/simulation_examples/rotation.py Outdated Show resolved Hide resolved

benflexcompute and others added 16 commits May 21, 2024 18:28

Merged volumes and surfaces into models to reflect latest design

a88eaac

[ModelRef] Added Field Definitions for **UserDefinedDynamics** (#271)

efefa03

* [ModelRef] Added Field Definitions for **UserDefinedDynamics** format * Update

Fix the wrong way of checking exceptions (#276)

8e944f1

Allowing entityList to accept None so the using class can set None de…

c56f91d

…fault for it when EntityList is not required (#277)

Merge branch 'develop' into UnderConstruction/SimulationInterface

616ae7e

[ModelRef] Added Field Definitions for **Outputs** (#270)

9928fa3

* [ModelRef] Added Field Definitions for Outputs Removed test artifacts Fix format * Added Entity Implementation * Comments addressed * Fix unit test * Addressed comments * Fix unit test?

Disable Simulation Pylint for now as it is not even finished. (#283)

0204165

[ModelRef] Added Field Definitions for **TimeStepping** (#272)

8d59a32

* [ModelRef] Added Field Definitions for **TimeStepping** Comments addressed * Comments addressed * Update default

Fix bug where time average outputs are not listed (#284)

d3d7a09

Added output format option (#285)

28b5df2

[ModelRef] Added Field Definitions for **ReferenceGeometry** (#280)

500443d

* [ModelRef] Added Field Definitions for **ReferenceGeometry** * added some thoughts in docstring * Fix unit test

Merge branch 'develop' into UnderConstruction/SimulationInterface

183b436

Add preprocess for base model (#281)

83426f9

feilin-flexcompute and others added 11 commits July 23, 2024 20:39

fix surface_mesh.py and upload examples for surface meshing (#389)

ab9864c

* fix surface_mesh and upload examples for surface meshing * lint

Nasser/move cases (#387)

6563b6f

* Symmetry Plane * Added XV15HoverMRF + fixed C_D and C_DES for kOmegaSST * Added NestedCylindersSRF * Fixed unit test * Added heatFluxCylinder * Added plateASI

Merge branch 'develop' into UnderConstruction/SimulationInterface

63cdbd5

Update unit test ref file hash

54489ed

Added discriminator for timestepping (#394)

c11cb79

Add discriminator for some single attribute models (#393)

ae362f7

* Add discriminator for some single attribute models * Fix unit tests

Rename Probe to ProbeGroup to avoid confusion (#396)

5e0f768

* Rename Probe to ProbeGroup to avoid confusion * Corrected alias

Just Update schema

c193fc7

Fix missing value error in __init__ signature (#398)

8b24218

* Fix missing value error in __init__ signature * Removed debug code

Merge branch 'develop' into UnderConstruction/SimulationInterface

65ae8bb

benflexcompute marked this pull request as ready for review August 1, 2024 15:50

benflexcompute requested review from maciej-flexcompute and yifan-flex August 1, 2024 15:52

yifan-flex approved these changes Aug 1, 2024

View reviewed changes

benflexcompute commented Aug 1, 2024

View reviewed changes

.github/workflows/test.yml Outdated Show resolved Hide resolved

yifan-flex reviewed Aug 1, 2024

View reviewed changes

.github/workflows/codestyle.yml Show resolved Hide resolved

benflexcompute and others added 4 commits August 1, 2024 14:09

Removed unused/unnecessary/outdated examples (#403)

aeebe7d

Remove v2 examples as they are not simulation related

c5b5133

Mistakenly delete too many examples

d334630

Update linting readme instruction and remove footpint of underconstru…

b3a02b5

…ction branch

maciej-flexcompute reviewed Aug 1, 2024

View reviewed changes

benflexcompute and others added 2 commits August 1, 2024 21:04

Comments adddressed

e2bee1e

maciej-flexcompute reviewed Aug 1, 2024

View reviewed changes

maciej-flexcompute approved these changes Aug 1, 2024

View reviewed changes

benflexcompute added 2 commits August 2, 2024 14:26

Added StandardAtmosphereModel implementation

8068bfb

Fix Lint

6e0afbc

benflexcompute merged commit a15be58 into develop Aug 2, 2024
12 checks passed

benflexcompute deleted the UnderConstruction/SimulationInterface branch August 2, 2024 14:32

[Tracking] Simulation Interface #253

[Tracking] Simulation Interface #253

Uh oh!

Conversation

benflexcompute commented May 8, 2024

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

benflexcompute Aug 1, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

benflexcompute Aug 1, 2024 •

edited

Loading